Support persistent-2.11 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
commented
Oct 30, 2020
src/Database/Esqueleto/PostgreSQL.hs
Outdated
| queryVals = | ||
| addVals updateVals | ||
| xs <- rawSql queryText queryVals | ||
| pure (head xs) |
There was a problem hiding this comment.
connUpsertSql was changed to take the field names directly. This is the only semantic change in the PR.
parsonsmatt
commented
Nov 4, 2020
| handler conn f = fmap head $ uncurry rawSql $ | ||
| (***) (f entDef (uDef :| [])) addVals $ updatesText conn | ||
| #endif |
There was a problem hiding this comment.
not a huge fan of CPP but it'd be nice to keep this available to 2.10 for a bit
…p/esqueleto into matt/support-persistent-2.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddock.stylish-haskelland otherwise adhered to the style guide.After submitting your PR:
Pending release of
2.11on Hackage, of course, but want to ensure that we're tracking changes.